[ML] Moving InferenceProcessorInfoExtractor to core to make available to inference plugin #109183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
maxhniebergall
approved these changes
May 29, 2024
jonathan-buttner
merged commit e688dea
into
elastic:checkPipelinesOnDeleteInferenceEndpoint
15 checks passed
maxhniebergall
added a commit
that referenced
this pull request
May 31, 2024
* renaming * check for pipeline references * add force and dry run options to request * add force delete and dry run options to Actions * Revert dependency on ml module * duplicate InferenceProcessorInfoExtractor to inference module * Ignore missing IngestMetadata during attempted endpoint delete * Update docs/changelog/109123.yaml * rename RestDeleteInference Action * fix dry run * Add integration test and misc improvements * Update 109123.yaml * merge fixes * Improvements from PR review * Moving shared pieces to core (#109183) * replace `model` in exception message with `inference endpoint` * test fix --------- Co-authored-by: Jonathan Buttner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
InferenceProcessorInfoExtractorclass and tests to the core plugin so the inference plugin can access it in addition to the ml plugin.